chore: update strategy dependency pins - #290
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48e2a4d6ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@61993bf261aeccf64b5a75428b9405f4e1d1d682 |
There was a problem hiding this comment.
When building the deploy image, Dockerfile:16 runs python -m pip install -r requirements.txt -c constraints.txt; pip install --help describes -c as constraining versions using the given constraints file. These new direct URL pins now disagree with constraints.txt lines 7-8, so the resolver is given mutually inconsistent requirements for us-equity-strategies and hk-equity-strategies and the Docker install path still cannot consume this requirements set. Please update the matching constraints entries (or stop constraining these packages) in the same change.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
1 participant
Summary\n- update strategy package pins to versions that depend on QPK 0063af3\n- fixes deploy pip conflict between platform QPK pin and strategy package QPK pin\n\n## Tests\n- python3.11 scripts/check_qpk_pin_consistency.py